Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PartitionConsumer.Close idempotent #1092

Merged
merged 1 commit into from
May 3, 2018
Merged

Make PartitionConsumer.Close idempotent #1092

merged 1 commit into from
May 3, 2018

Conversation

dim
Copy link
Contributor

@dim dim commented Apr 29, 2018

There is a use-case in sarama-cluster where I want to defer pcm.Close() as well as call it explicitly to ensure it has actually stopped before proceeding with the next steps. I am currently wrapping the call in a sync.Once myself, but moving this to sarama seems generally a good idea.

@eapache
Copy link
Contributor

eapache commented May 3, 2018

Fair enough, thanks.

@eapache eapache merged commit 1c45a00 into IBM:master May 3, 2018
@dim dim deleted the fix/pc-safe-close branch September 12, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants